Rails 5 fix for undefined method select_recurring
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sahild Thanks for submitting a patch. FYI, I'm no longer involved on this project. |
|
Any update on this? |
|
👍 What's going on with this? |
|
So is anyone able to merge this? |
|
any merge ?? and @sahild thnk for the pr using this until it merge. |
|
+1 |
gustavrannestig
added a commit
to prototypsthlm/recurring_select
that referenced
this pull request
Jan 12, 2018
This should allow usage of this gem with rails 5. Note that there is an unmerged to the original project at: gregschmit#115
|
+1 |
|
Is anyone still working on this project? |
|
Is this repository no longer maintained? |
|
Merge this please :( |
|
Closed by #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Rails 5 upgrade, gem stopped working with this error:
ActionView::Template::Error (undefined method
select_recurring' for #<#<Class:0x007fa3ae96a600>:0x007fa3ae9681c0>). at this line= f.select_recurring :current_custom_rule, []`I added this quick fix to make this method available for rails 5.
If you can release a version with this fix i will be able to use this gem again from 'rubygems.org'